Convert bug report to new syntax#5264
Merged
kenjis merged 1 commit intocodeigniter4:developfrom Nov 1, 2021
Merged
Conversation
MGatner
requested changes
Oct 31, 2021
Member
MGatner
left a comment
There was a problem hiding this comment.
This is awesome! Thanks for tackling this - it's been on my mind for a while but just never sat down with the file format. A few comments...
8a65198 to
b6285e8
Compare
Contributor
|
Why is there two descriptions asking for the expected behavior? |
kenjis
reviewed
Oct 31, 2021
MGatner
reviewed
Nov 1, 2021
Member
MGatner
left a comment
There was a problem hiding this comment.
I agree with Kenji's change, then this is ready IMO.
b6285e8 to
51966d0
Compare
kenjis
approved these changes
Nov 1, 2021
Member
Author
|
I'll be pushing a direct commit. There's a typo |
Member
|
Where did you get the error message? |
Member
Author
|
In the file itself, there is a validation message. |
Member
Author
|
The new issue form looks savvy. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4944
Checklist: