Skip to content

Convert bug report to new syntax#5264

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
paulbalandan:issue-forms
Nov 1, 2021
Merged

Convert bug report to new syntax#5264
kenjis merged 1 commit intocodeigniter4:developfrom
paulbalandan:issue-forms

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
Closes #4944

Checklist:

  • Securely signed commits

@paulbalandan paulbalandan requested a review from MGatner October 31, 2021 12:19
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for tackling this - it's been on my mind for a while but just never sat down with the file format. A few comments...

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
@paulbalandan paulbalandan force-pushed the issue-forms branch 2 times, most recently from 8a65198 to b6285e8 Compare October 31, 2021 12:46
@paulbalandan paulbalandan requested a review from MGatner October 31, 2021 12:46
@sfadschm
Copy link
Copy Markdown
Contributor

Why is there two descriptions asking for the expected behavior?
Lines 73 and 88.

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Kenji's change, then this is ready IMO.

@kenjis kenjis merged commit 9fb5164 into codeigniter4:develop Nov 1, 2021
@paulbalandan paulbalandan deleted the issue-forms branch November 1, 2021 05:28
@paulbalandan
Copy link
Copy Markdown
Member Author

I'll be pushing a direct commit. There's a typo

There is a problem with this template

body[1]: dropdowm is not a valid input type. Learn more.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Nov 1, 2021

Where did you get the error message?
There is no new Issue form, I was looking for why.

@paulbalandan
Copy link
Copy Markdown
Member Author

In the file itself, there is a validation message.

@paulbalandan
Copy link
Copy Markdown
Member Author

The new issue form looks savvy. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue Forms

4 participants